r200004 - Adding a new diagnostics group (-Wattributes) which covers both UnknownAttributes and IgnoredAttributes.

[Aaron Ballman]

Thank you for the history lesson (and tying it into this commit)!

~Aaron

On Fri, Jan 24, 2014 at 4:48 PM, Alp Toker <alp at nuanti.com> wrote:
> Nice, this is a good distinction to have.
>
> For the record, here's some background as to how it got this way:
>
>   [cfe-dev] -Wattributes versus -Wunknown-attributes
>   http://lists.cs.uiuc.edu/pipermail/cfe-dev/2011-June/015412.html
>
> Alp.
>
>
> On 24/01/2014 14:16, Aaron Ballman wrote:
>>
>> Author: aaronballman
>> Date: Fri Jan 24 08:16:23 2014
>> New Revision: 200004
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=200004&view=rev
>> Log:
>> Adding a new diagnostics group (-Wattributes) which covers both
>> UnknownAttributes and IgnoredAttributes.
>>
>> Modified:
>>      cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>>
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=200004&r1=200003&r2=200004&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Fri Jan 24 08:16:23
>> 2014
>> @@ -340,8 +340,10 @@ def Uninitialized  : DiagGroup<"uninitia
>>   def UnknownPragmas : DiagGroup<"unknown-pragmas">;
>>   def UnknownWarningOption : DiagGroup<"unknown-warning-option">;
>>   def NSobjectAttribute : DiagGroup<"NSObject-attribute">;
>> -def UnknownAttributes : DiagGroup<"attributes">;
>> +def UnknownAttributes : DiagGroup<"unknown-attributes">;
>>   def IgnoredAttributes : DiagGroup<"ignored-attributes">;
>> +def Attributes : DiagGroup<"attributes", [UnknownAttributes,
>> +                                          IgnoredAttributes]>;
>>   def UnnamedTypeTemplateArgs : DiagGroup<"unnamed-type-template-args",
>>
>> [CXX98CompatUnnamedTypeTemplateArgs]>;
>>   def UnsupportedFriend : DiagGroup<"unsupported-friend">;
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> --
> http://www.nuanti.com
> the browser experts
>