[PATCH] Add a -verify-pch option to clang -cc1

[Ben Langmuir]

Based on an off-list discussion, I’ve updated this patch to not check for configuration mismatches (e.g. different langopts), since checking for staleness is the interesting case to check for and adding all the requisite langopts to the command line increases the complexity of using the feature.

Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: verify-pch.patch
Type: application/octet-stream
Size: 20328 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140124/90d90801/attachment.obj>
-------------- next part --------------


On Jan 21, 2014, at 8:18 PM, Ben Langmuir <blangmuir at apple.com> wrote:

> 
>> Looks good!
>> Could you also add a driver option (maybe "--verify-pch") ?
> 
> Sure, I’ve added -verify-pch to the driver as well.  I kept the same spelling between the two options.  The biggest change here is that we don’t want the driver to pass through -x TYPE to cc1 for an input file that is a pch when we are verifying, since we want to verify the *source* language.  Right now I am omitting "-x TYPE" when -verify-pch is set AND the input file has a .pch extension.  I’m not sure whether checking the extension is a good idea, but it is consistent with other bits of the compiler that will assume the input is an object file if it has no extension and no explicit -x option.  I’m happy to change it.
> 
> Ben
> 
> <verify-pch.patch>
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits