r199460 - Refine diagnostic: attribute 'nonnull' applies to both functions and methods.

[Ted Kremenek]

Thank you!

> On Jan 17, 2014, at 6:44 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
> 
> Yeah, it was as I feared, we had no tests for this at all. I've added
> one in 199496. :-)
> 
> ~Aaron
> 
>> On Fri, Jan 17, 2014 at 8:23 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>> Good catch, thank you!  We should probably have a test for this
>> though. Do you mind adding one, or would you like me to take a stab at
>> it?
>> 
>> ~Aaron
>> 
>>> On Thu, Jan 16, 2014 at 11:58 PM, Ted Kremenek <kremenek at apple.com> wrote:
>>> Author: kremenek
>>> Date: Thu Jan 16 22:58:29 2014
>>> New Revision: 199460
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=199460&view=rev
>>> Log:
>>> Refine diagnostic: attribute 'nonnull' applies to both functions and methods.
>>> 
>>> Modified:
>>>    cfe/trunk/include/clang/Basic/Attr.td
>>> 
>>> Modified: cfe/trunk/include/clang/Basic/Attr.td
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Attr.td?rev=199460&r1=199459&r2=199460&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/include/clang/Basic/Attr.td (original)
>>> +++ cfe/trunk/include/clang/Basic/Attr.td Thu Jan 16 22:58:29 2014
>>> @@ -680,7 +680,7 @@ def NoMips16 : InheritableAttr, TargetSp
>>> def NonNull : InheritableAttr {
>>>   let Spellings = [GNU<"nonnull">, CXX11<"gnu", "nonnull">];
>>>   let Subjects = SubjectList<[ObjCMethod, FunctionLike, HasFunctionProto],
>>> -                             WarnDiag, "ExpectedFunction">;
>>> +                             WarnDiag, "ExpectedFunctionOrMethod">;
>>>   let Args = [VariadicUnsignedArgument<"Args">];
>>>   let AdditionalMembers =
>>> [{bool isNonNull(unsigned idx) const {
>>> 
>>> 
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits