[PATCH] Add implementations of _cpuid and _xgetbv to Intrin.h

Reid Kleckner rnk at google.com
Thu Jan 16 15:23:48 PST 2014


  LGTM


================
Comment at: lib/Headers/Intrin.h:783
@@ +782,3 @@
+#if __i386__
+  __asm__ ("  pushl  %%ebx\n"
+           "  cpuid\n"
----------------
This ebx preservation is only necessary for ELF PIC stuff.  Can we just use "b"(__info[1]) below and kill the pushing?


http://llvm-reviews.chandlerc.com/D2564



More information about the cfe-commits mailing list