[PATCH] MS ABI: Improve selection of an inheritance model
Aaron Ballman
aaron at aaronballman.com
Thu Jan 16 11:49:45 PST 2014
On Thu, Jan 16, 2014 at 2:24 PM, Reid Kleckner <rnk at google.com> wrote:
>
>
> ================
> Comment at: lib/AST/MicrosoftCXXABI.cpp:176
> @@ -160,7 +175,3 @@
> switch (Inheritance) {
> - case MSIM_Unspecified: ++Ints; // VBTableOffset
> - case MSIM_Virtual: ++Ints; // VirtualBaseAdjustmentOffset
> - case MSIM_MultiplePolymorphic:
> - case MSIM_Multiple: ++Ints; // NonVirtualBaseAdjustment
> - case MSIM_SinglePolymorphic:
> - case MSIM_Single: break; // Nothing
> + case MSInheritanceAttr::Keyword___unspecified_inheritance:
> + ++Ints; // VBTableOffset
> ----------------
> Oh, I mentioned on IRC that these names are reserved. We should fix it in the tablegen attribute stuff eventually.
That should be resolved with r199414, good catch!
~Aaron
More information about the cfe-commits
mailing list