r199347 - Disable and XFAIL a test that never worked

[Aaron Ballman]

CCing Delesley as well, since he knows the most about thread safety analysis.

~Aaron

On Wed, Jan 15, 2014 at 10:00 PM, Alp Toker <alp at nuanti.com> wrote:
> Hi David,
>
> Any idea what happened here?
>
> The breakage doesn't seem major but I'm not familiar with the thread safety
> analysis, be great if you can take a look.
>
> Alp.
>
>
> On 16/01/2014 02:36, Alp Toker wrote:
>>
>> Author: alp
>> Date: Wed Jan 15 20:36:24 2014
>> New Revision: 199347
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=199347&view=rev
>> Log:
>> Disable and XFAIL a test that never worked
>>
>> -verify was simply ignored by the driver.
>>
>> This commit fixes the RUN line and XFAILs the test, unblocking changes to
>> ban
>> use of the driver in Sema tests and avoid problems like this.
>>
>> Modified:
>>      cfe/trunk/test/Sema/warn-thread-safety-analysis.c
>>
>> Modified: cfe/trunk/test/Sema/warn-thread-safety-analysis.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/warn-thread-safety-analysis.c?rev=199347&r1=199346&r2=199347&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/Sema/warn-thread-safety-analysis.c (original)
>> +++ cfe/trunk/test/Sema/warn-thread-safety-analysis.c Wed Jan 15 20:36:24
>> 2014
>> @@ -1,4 +1,6 @@
>> -// RUN: %clang -fsyntax-only -verify -Wthread-safety -Wthread-safety-beta
>> -fcxx-exceptions %s
>> +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety
>> -Wthread-safety-beta -fcxx-exceptions %s
>> +// FIXME: This test never worked due to a broken RUN line.
>> +// XFAIL: *
>>     #define LOCKABLE            __attribute__ ((lockable))
>>   #define SCOPED_LOCKABLE     __attribute__ ((scoped_lockable))
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits