r199169 - Consumed analysis: add two new attributes which fine-tune the behavior of

[Aaron Ballman]

On Wed, Jan 15, 2014 at 5:40 PM, Delesley Hutchins <delesley at google.com> wrote:
>> Why is this code now commented out?
>
> It's looked "fishy" to me ;-) and it didn't break any tests when I
> removed it, but I left it there in case I ever discover why it was
> there.

Can you put a FIXME with an explanation in then?

>
>> I think you have to check whether the function is static or not as well.
>
> Good point.  Thanks!
>
>> These can be hoisted into the enclosing if.
>
> Will do.
>
>> Quite a few style guideline mishaps in here (extra newlines, curly
>> braces when they should be elided, else clauses on their own line,
>> etc). It might make sense to run clang-format over the file at some
>> point.
>
> Maybe, but we're not supposed to change SVN blame...

I've heard that you can run it over just your patch contents (but have
yet to try this).

~Aaron