r198818 - [ms-abi] Refactor Microsoft Record Layout

[Warren Hunt]

Thanks Dave!  Yes, the code was correct as intended and the warning simply
needed to be suppressed.  I was curious as to why I hadn't gotten the
warning but then realized that I build clang with Visual Studio.

-Warren


On Wed, Jan 8, 2014 at 6:40 PM, dblaikie at gmail.com <dblaikie at gmail.com>wrote:

>
>
> On Wed Jan 08 2014 at 6:38:39 PM, Alexander Kornienko <alexfh at google.com>
> wrote:
>
>> This CL introduces a warning when building with clang:
>>
>> tools/clang/lib/AST/RecordLayoutBuilder.cpp:2493:33: warning: suggest
>> parentheses around ‘&&’ within ‘||’ [-Wparentheses]
>>
>> Could you, please, fix it?
>>
>
> Fixed in r198837.
>
> Warren - feel free to fix it in other ways if appropriate, but a cursory
> reading of the code seemed to indicate that the precedence was what you
> wanted & the warning just needed to be suppressed.
>
>
>>
>> Thanks!
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140109/047e54b5/attachment.html>