r198858 - Disable LeakSanitizer in TableGen binaries, see PR18325

[Alp Toker]

On 09/01/2014 11:14, Kostya Serebryany wrote:
>
>
>
> On Thu, Jan 9, 2014 at 3:02 PM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>
>     On 09/01/2014 09:26, Kostya Serebryany wrote:
>
>         Author: kcc
>         Date: Thu Jan  9 03:26:26 2014
>         New Revision: 198858
>
>         URL: http://llvm.org/viewvc/llvm-project?rev=198858&view=rev
>         Log:
>         Disable LeakSanitizer in TableGen binaries, see PR18325
>
>         Modified:
>              cfe/trunk/utils/TableGen/TableGen.cpp
>
>         Modified: cfe/trunk/utils/TableGen/TableGen.cpp
>         URL:
>         http://llvm.org/viewvc/llvm-project/cfe/trunk/utils/TableGen/TableGen.cpp?rev=198858&r1=198857&r2=198858&view=diff
>         ==============================================================================
>         --- cfe/trunk/utils/TableGen/TableGen.cpp (original)
>         +++ cfe/trunk/utils/TableGen/TableGen.cpp Thu Jan  9 03:26:26 2014
>         @@ -255,3 +255,10 @@ int main(int argc, char **argv) {
>               return TableGenMain(argv[0], &ClangTableGenMain);
>           }
>         +
>         +extern "C" {
>         +// Disable LeakSanitizer for this binary as it has too many
>         leaks that are not
>         +// very interesting to fix. __lsan_is_turned_off is explained in
>         +// compiler-rt/include/sanitizer/lsan_interface.h
>         +int __lsan_is_turned_off() { return 1; }
>         +}  // extern "C"
>
>
>     Hi Kostya,
>
>     This doesn't look correct and fires warnings my my strict checks
>     build.
>
>     Double-underscore prefixed identifiers are strictly reserved for
>     the implementation.
>
>
> all asan/msan/lsan/tsan interface functions have __ prefix exactly 
> because this prefix is reserved for implementation,
> so this is clearly what I intended to write.

Kostya,

The sanitizers are part of the implementation and should feel free to 
introduce double-underscore prefixed names.

This review is for a change to TableGen -- which clearly isn't part of 
the implementation.

It is not at liberty to introduce new reserved names.

Alp.


> Another question is how to silence your checker: please give us more 
> info on what that is.
>
> --kcc
>
>
>     Alp.
>
>
>
>
>
>
>         _______________________________________________
>         cfe-commits mailing list
>         cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>         http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>     -- 
>     http://www.nuanti.com
>     the browser experts
>
>

-- 
http://www.nuanti.com
the browser experts