[PATCH] Don't emit diagnostics for system headers.

Daniel Jasper djasper at google.com
Wed Jan 8 07:21:04 PST 2014


  I think there is a better method to call, otherwise looks good.


================
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.h:121-122
@@ +120,4 @@
+    // from non-user code.
+    if (Diags->getSourceManager().getFileCharacteristic(Info.getLocation()) !=
+        SrcMgr::C_User)
+      return;
----------------
I think you could/should use:

  Diags->getSourceManager().isInSystemHeader(Info.getLocation())


http://llvm-reviews.chandlerc.com/D2519

BRANCH
  svn

ARCANIST PROJECT
  clang-tools-extra



More information about the cfe-commits mailing list