[PATCH] Fix leak in lib/CodeGen/CGException.cpp, PR18318

[Kostya Serebryany]

  PTAL
  Introduced EHCatchScope::clearHandlerBlocks

Hi chandlerc, dblaikie,

http://llvm-reviews.chandlerc.com/D2474

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2474?vs=6272&id=6273#toc

Files:
  lib/CodeGen/CGException.cpp
  lib/CodeGen/CGCleanup.h

Index: lib/CodeGen/CGException.cpp
===================================================================
--- lib/CodeGen/CGException.cpp
+++ lib/CodeGen/CGException.cpp
@@ -1244,6 +1244,7 @@
 
   // If the catch was not required, bail out now.
   if (!CatchScope.hasEHBranches()) {
+    CatchScope.clearHandlerBlocks();
     EHStack.popCatch();
     return;
   }
Index: lib/CodeGen/CGCleanup.h
===================================================================
--- lib/CodeGen/CGCleanup.h
+++ lib/CodeGen/CGCleanup.h
@@ -194,6 +194,15 @@
     return getHandlers()[I];
   }
 
+  // Clear all handler blocks.
+  // FIXME: it's better to always call clearHandlerBlocks in DTOR and have a
+  // 'takeHandler' or some such function which removes ownership from the
+  // EHCatchScope object if the handlers should live longer than EHCatchScope.
+  void clearHandlerBlocks() {
+    for (unsigned I = 0, N = getNumHandlers(); I != N; ++I)
+      delete getHandler(I).Block;
+  }
+
   typedef const Handler *iterator;
   iterator begin() const { return getHandlers(); }
   iterator end() const { return getHandlers() + getNumHandlers(); }
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2474.2.patch
Type: text/x-patch
Size: 1130 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131226/bc65c856/attachment.bin>