r197972 - Support and use token kinds as diagnostic arguments

[Alp Toker]

On 25/12/2013 00:49, Faisal Vali wrote:
> Hi Alp,
>     This patch prevents clang from compiling in VS2010 (which supports 
> strong enums) - that's because forward declared enums (which are being 
> used in Diagnostic.h) aren't supported till VS2013.

Looks like they're fine in VS2012, while VS2010 only had strongly 
/typed/ enums. Patched up in LLVM r197992.

Thanks for spotting this Faisal

Alp.



>
> Below, LLVM_HAS_STRONG_ENUMS is being used to assume support for 
> forward declared enums:
>
> #if LLVM_HAS_STRONG_ENUMS
>   namespace tok {
>   enum TokenKind : unsigned;
>   }
> #endif
>
>
> See: http://msdn.microsoft.com/en-us/library/vstudio/hh567368.aspx
>
> Thanks!
>
> Faisal Vali
>

-- 
http://www.nuanti.com
the browser experts