[patch] Don't let invalid methods mark their RecordDecl invalid

Alp Toker alp at nuanti.com
Fri Dec 20 17:18:09 PST 2013


On 21/12/2013 00:53, Reid Kleckner wrote:
> On Fri, Dec 20, 2013 at 4:27 PM, Nico Weber <thakis at chromium.org 
> <mailto:thakis at chromium.org>> wrote:
>
>     No, the patch changes things to not mark a class invalid if one of
>     its methods is invalid. This was the only place I could find where
>     a class was marked invalid after its definition is complete.
>     (Hence with this patch, C's superclass A will be valid too, only
>     its method stays invalid, like with the first snippet).
>
>
> OK, this makes sense, we already have a complete class, and so far as 
> we know this is the only place we would mark a record decl invalid 
> after completing it.

Indeed. I've added an assertion for this in r197850.

Alp.


>  Go for it.
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list