[patch] Don't let invalid methods mark their RecordDecl invalid

[Reid Kleckner]

+John, since it was his code.

Are there other ways we can get an invalid record decl and then do layout
on a derived class to trigger PR18284?  If so, it seems like this doesn't
fix the underlying issue.


On Fri, Dec 20, 2013 at 3:59 PM, Nico Weber <thakis at chromium.org> wrote:

> Hi,
>
> if a method decl is invalid, clang currently sometimes marks the method's
> record decl invalid, and sometimes doesn't (and this ends up confusing
> record layout). For consistency, and to fix PR18284, never do this.
>
> (The code to do this was added in
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100809/033154.html, but the test from that revision is still passing.)
>
> See also this thread
> http://lists.cs.uiuc.edu/pipermail/cfe-dev/2013-December/034216.html for
> some discussion.
>
> Nico
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131220/e7bce0e8/attachment.html>