r197842 - Remove obsolete preamble FIXME

Alp Toker alp at nuanti.com
Fri Dec 20 14:27:20 PST 2013


Author: alp
Date: Fri Dec 20 16:27:20 2013
New Revision: 197842

URL: http://llvm.org/viewvc/llvm-project?rev=197842&view=rev
Log:
Remove obsolete preamble FIXME

The MD5 is checked since r197755 which is as good as comparing buffer contents
in this context.

Modified:
    cfe/trunk/lib/Frontend/ASTUnit.cpp

Modified: cfe/trunk/lib/Frontend/ASTUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/ASTUnit.cpp?rev=197842&r1=197841&r2=197842&view=diff
==============================================================================
--- cfe/trunk/lib/Frontend/ASTUnit.cpp (original)
+++ cfe/trunk/lib/Frontend/ASTUnit.cpp Fri Dec 20 16:27:20 2013
@@ -1480,8 +1480,6 @@ llvm::MemoryBuffer *ASTUnit::getMainBuff
              REnd = PreprocessorOpts.remapped_file_buffer_end();
            !AnyFileChanged && R != REnd;
            ++R) {
-        // FIXME: Should we actually compare the contents of file->buffer
-        // remappings?
         OverriddenFiles[R->first] =
             PreambleFileHash::createForMemoryBuffer(R->second);
       }





More information about the cfe-commits mailing list