[PATCH] Enable layering check in unavailable modules

Daniel Jasper djasper at google.com
Fri Dec 20 02:52:16 PST 2013



================
Comment at: include/clang/Lex/ModuleMap.h:236
@@ +235,3 @@
+  ///
+  /// \param File The included file.
+  void diagnoseHeaderInclusion(Module *RequestingModule,
----------------
Manuel Klimek wrote:
> I'd probably remove all the empty comment lines...
I agree in general, but this file uses these empty lines quite consistently. So I'd rather not break that.

================
Comment at: lib/Lex/ModuleMap.cpp:205
@@ +204,3 @@
+                                        const FileEntry *File) {
+  if (RequestingModule != SourceModule)
+    return;
----------------
Manuel Klimek wrote:
> Please re-add the comment from the other file.
Done.


http://llvm-reviews.chandlerc.com/D2442



More information about the cfe-commits mailing list