[PATCH] Remove OpenCL-specific type parsing

Joey Gouly joey.gouly at arm.com
Wed Dec 18 07:13:18 PST 2013


LGTM, a nice cleanup!

Joey

-----Original Message-----
From: Alp Toker [mailto:alp at nuanti.com] 
Sent: 17 December 2013 21:33
To: cfe commits
Cc: Joey Gouly
Subject: [PATCH] Remove OpenCL-specific type parsing

Hi,

This patch kills off custom type specifier and keyword handling of 
OpenCL C data types.

Although the OpenCL spec describes them as keywords, we can handle them 
more elegantly as built-in types. This should provide better error 
correction and code completion support as well as simplifying the 
implementation.

The primary intention is however to simplify the C/C++ parser and save 
some packed bits on AST structures that had been extended to support 
OpenCL in the past.


  include/clang/Basic/Specifiers.h   |   10 -----
  include/clang/Basic/TokenKinds.def |    9 -----
  include/clang/Sema/DeclSpec.h      |    8 ----
  include/clang/Sema/Sema.h          |    2 +
  lib/Parse/ParseDecl.cpp            |   62 
-------------------------------------
  lib/Parse/ParseExpr.cpp            |   10 -----
  lib/Parse/ParseTentative.cpp       |    8 ----
  lib/Sema/DeclSpec.cpp              |   16 ---------
  lib/Sema/Sema.cpp                  |   18 ++++++++++
  lib/Sema/SemaTemplateVariadic.cpp  |    8 ----
  lib/Sema/SemaType.cpp              |   32 -------------------
  11 files changed, 22 insertions(+), 161 deletions(-)


Alp.

-- 
http://www.nuanti.com
the browser experts







More information about the cfe-commits mailing list