r197521 - Use the integrated assembler by default on FreeBSD/ppc and ppc64.

Roman Divacky rdivacky at freebsd.org
Wed Dec 18 02:00:14 PST 2013


There's a bunch of system instructions not implemented preventing eg. kernel
assembly. I think this is what made the IBM people want it off by default.

For me it's fine on FreeBSD because we can assemble FreeBSD kernel just fine.

On Tue, Dec 17, 2013 at 09:18:17PM -0500, Rafael Avila de Espindola wrote:
> Awesome! What prevents using it on all elf systems?
> 
> Sent from my iPhone
> 
> > On Dec 17, 2013, at 15:34, Roman Divacky <rdivacky at freebsd.org> wrote:
> > 
> > Author: rdivacky
> > Date: Tue Dec 17 14:34:25 2013
> > New Revision: 197521
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=197521&view=rev
> > Log:
> > Use the integrated assembler by default on FreeBSD/ppc and ppc64.
> > 
> > Modified:
> >    cfe/trunk/lib/Driver/ToolChains.h
> > 
> > Modified: cfe/trunk/lib/Driver/ToolChains.h
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.h?rev=197521&r1=197520&r2=197521&view=diff
> > ==============================================================================
> > --- cfe/trunk/lib/Driver/ToolChains.h (original)
> > +++ cfe/trunk/lib/Driver/ToolChains.h Tue Dec 17 14:34:25 2013
> > @@ -507,7 +507,12 @@ public:
> >   virtual void
> >   AddClangCXXStdlibIncludeArgs(const llvm::opt::ArgList &DriverArgs,
> >                                llvm::opt::ArgStringList &CC1Args) const;
> > -
> > +  virtual bool IsIntegratedAssemblerDefault() const {
> > +    if (getTriple().getArch() == llvm::Triple::ppc ||
> > +        getTriple().getArch() == llvm::Triple::ppc64)
> > +      return true;
> > +    return Generic_ELF::IsIntegratedAssemblerDefault();
> > +  }
> > 
> >   virtual bool UseSjLjExceptions() const;
> > protected:
> > 
> > 
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list