[PATCH] Fix crash in CFGReachabilityAnalysis triggered by IdempotentOperationChecker.

[Ted Kremenek]

  Let's make this an assertion instead of a conditional check.  This is an invariant, and not something we should soft fail.  The bug is in the calling code.

http://llvm-reviews.chandlerc.com/D2427