[PATCH] [ms-cxxabi] Elide dtor access checks for pass-by-val objects in callees

Hans Wennborg hans at chromium.org
Tue Dec 17 14:49:06 PST 2013


  > Rather than threading a CheckDtorAccess bool through everywhere, I think you can inline a small portion of the body of FinalizeVarWithDestructor into CheckFunctionDefinition and skip the access check. Most of it is probably dead. That's what I did initially in http://llvm-reviews.chandlerc.com/D929.

  That just removes one level of threading though. We still need to thread it through MarkFunctionReferenced to suppress access checks for base class dtors etc. when defining an implicit destructor, and that's where the ugliness comes from :/

http://llvm-reviews.chandlerc.com/D2409



More information about the cfe-commits mailing list