r197229 - clang-check to ignore -no-integrated-as because certain drivers can't handle it

Artyom Skrobov Artyom.Skrobov at arm.com
Mon Dec 16 01:56:47 PST 2013


Thank you for noticing!

Should we add

// RUN: not clang-check "%s" -- -target x86_64-win32 -no-integrated-as -c
2>&1 | FileCheck %s

into multi-jobs.cpp, to make sure this doesn't get broken again?


-----Original Message-----
From: NAKAMURA Takumi [mailto:geek4civic at gmail.com] 
Sent: 14 December 2013 13:53
To: Artyom Skrobov
Cc: cfe-commits
Subject: Re: r197229 - clang-check to ignore -no-integrated-as because
certain drivers can't handle it

> +  // Remove -no-integrated-as; it's not used for syntax checking,
> +  // and it confuses targets which don't support this option.
> +  std::remove_if(Args.begin(), Args.end(),
MatchesAny(std::string("no-integrated-as")));

Oh no, ... did you expect to match "-no-integrated-as" ?
Fixed in r197309.

You can reconfirm with;
  clang-check clang/test/Tooling/multi-jobs.cpp -- -target
x86_64-win32 -no-integrated-as -c








More information about the cfe-commits mailing list