[PATCH] Stop crashing on empty asm input constraints

Duncan P. N. Exon Smith dexonsmith at apple.com
Sun Dec 15 19:31:43 PST 2013


On 2013 Dec 15, at 17:04, Justin Bogner <mail at justinbogner.com> wrote:

> I think (*Name == '\0') makes the intention clearer here. From a
> rudimentary grep the two styles are pretty much 50/50 in LLVM, so YMMV.
> 
> In any case, this is obviously correct. LGTM.

I left it unchanged to match the style of the while loop immediately following.

>>   while (*Name) {

Thanks for the review!  In r197362.



More information about the cfe-commits mailing list