[PATCH] Remove PragmaIntroducerKind?

[Kim Gräsman]

Hi Renato,

On Sat, Dec 14, 2013 at 12:52 PM, Renato Golin <renato.golin at linaro.org> wrote:
> On 14 December 2013 10:12, Kim Gräsman <kim.grasman at gmail.com> wrote:
>
>> I'm still on the fence whether it's a good idea to build a separate
>> tool to test PPCallbacks, because failures would signal problems with
>> the tool, not with PPCallbacks. Intuitively, I think unit tests would
>> be better, but that was discouraged by someone else in the original
>> review.
>
>
> I like unit tests, but not to the point where it makes things harder. Some
> of the comments that have been said in this list are very pertinent (and I
> had my share of problems with unit tests, code coverage, etc), so I won't
> defend any strategy in specific.
>
> If you could get your tests somewhere, it'd be already great. The test-suite
> seems like a good compromise, even if just temporarily.

I think for PPCallbacks my preference would be unit tests, but I
haven't seen the arguments either way, so I may be missing something.

Given how it's a programmatic interface, it makes sense to me to test
it in a code-centric setting to document what tools can expect from
it.

But I'm not engaged in Clang development enough to have an informed
opinion beyond that it'd be nice if there was test coverage :-)

- Kim