[PATCH] Allow regexes in all verifier directives: drop the expected-(error|warning|note)-re, variants

[Hans Wennborg]

On Fri, Dec 13, 2013 at 7:49 AM, Alp Toker <alp at nuanti.com> wrote:
> Hans,
>
> Instead of reverting, I think it's OK* to back out just the part of the
> changes that made -re optional.

I hadn't committed that part yet, but I still plan to do so. I think
Richard summarized it well. It's not that much harder to find tests
that have regexes in them, and this does make -verify's interface
simpler and more similar to FileCheck (in fact, I always expected it
to work like this before I tried to put in regexes and found out
otherwise).

> * I'm still also somewhat opposed to the {{{{}}}} syntax and Richard's
> assessment -- after all, preprocessor #if conditionals and C if statements
> also do the same thing but nobody has yet proposed that they should look the
> same.

The expressions they take look very similar though.

> Making the -verify syntax similar to FileCheck is /very/ confusing to
> newcomers who need to be aware that they are very distinct testing tools --
> sometimes different is good and I'd like to encourage more people get
> involved writing lit tests and this raises the barrier of understanding.

I think it's the reverse. Both -verify's and FileCheck's directives
now accept regexes enclosed in {{'s. I think that's less confusing to
newcomers.

 - Hans

> On 12/12/2013 21:52, Hans Wennborg wrote:
>>
>> On Thu, Dec 12, 2013 at 11:38 AM, Alp Toker <alp at nuanti.com> wrote:
>>>
>>> Reading through SVN history shows that over years any syntax that isn't
>>> shored up tends to break.
>>
>> Yes, I agree we might have relaxed these tests a bit too much.
>>
>>>> Requiring -re on directives with regexes makes them easier to grep
>>>> for, but I don't know how important that is.
>>>
>>> Looking at the changes today, I'm starting to think anything to make
>>> regex
>>> expressions stand out is a good idea.
>>
>> I think they do stand out a bit already with the extra {{'s, but sure,
>> explicitly putting -re on the directives makes them stand out even
>> more.
>>
>> Anyway, I'm curious to hear what Richard thinks here.
>>
>>   - Hans