[PATCH] Eliminate BinaryTypeTraitExpr

[Alp Toker]

On 13/12/2013 18:23, Richard Smith wrote:
>      case EXPR_BINARY_TYPE_TRAIT:
> -      S = new (Context) BinaryTypeTraitExpr(Empty);
> +      llvm_unreachable("obsolete");
>        break;
>
> Please just remove this, and EXPR_BINARY_TYPE_TRAIT.

Great, if there is no need to maintain the serialization I'll get rid of 
that too.

>
>
> I don't really like having BTT_* and TT_* in the same enum, with 
> default: clauses appearing in various switches. Are you planning on 
> folding the trait-handling code together more (and dropping the 'B')? 
> If so, looks fine as a step towards that.

Indeed, the BTT/TT prefix and remaining differences will melt away in 
smaller upcoming tidy-ups which I'll land directly.

Are we good to go with the initial MSVC 2013 traits as well?

Thanks for reviewing!

Alp.


>
>
> On Fri, Dec 13, 2013 at 6:58 AM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>     Forgot to mention, this is built on top of the MSVC 2013 type
>     trait support patch which has yet to land. Delta should be small
>     though.
>
>     Alp.
>
>
>     On 13/12/2013 14:56, Alp Toker wrote:
>
>         There's nothing special about type traits accepting two arguments.
>
>         The attached patch eliminates BinaryTypeTraitExpr and switches
>         all related handling over to TypeTraitExpr.
>
>         Also fixes a CodeGen failure with variadic type traits
>         appearing in a non-constant expression.
>
>         The BTT/TT prefix distinction is retained for the time being.
>
>         This is part of the ongoing work to unify type traits.
>
>          26 files changed, 62 insertions(+), 289 deletions(-)
>
>         Alp.
>
>
>     -- 
>     http://www.nuanti.com
>     the browser experts
>
>     _______________________________________________
>     cfe-commits mailing list
>     cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>

-- 
http://www.nuanti.com
the browser experts