[PATCH] array new of a multidimensional array with an initializer still broken
Richard Smith
richard at metafoo.co.uk
Fri Dec 13 11:02:23 PST 2013
Hmm. This code intends to initialize the individual array base elements, one at a time. That seems like the right approach here, since it'll generate less code. I think the problem is that the wrong type is being passed into `StoreAnyExprIntoOneUnit`, but directly fixing that doesn't really work, because the `Init` expression has the wrong type at this point.
So... if we want to get a super-last-minute fix for this into 3.4, I think your patch is fine, but we can and should do a lot better here long-term. You need a testcase, or at least to update the existing testcase.
Thanks for the fix!
http://llvm-reviews.chandlerc.com/D2398
More information about the cfe-commits
mailing list