[PATCH] Allow regexes in all verifier directives: drop the expected-(error|warning|note)-re, variants
Hans Wennborg
hans at chromium.org
Thu Dec 12 13:52:56 PST 2013
On Thu, Dec 12, 2013 at 11:38 AM, Alp Toker <alp at nuanti.com> wrote:
> Reading through SVN history shows that over years any syntax that isn't
> shored up tends to break.
Yes, I agree we might have relaxed these tests a bit too much.
>> Requiring -re on directives with regexes makes them easier to grep
>> for, but I don't know how important that is.
>
> Looking at the changes today, I'm starting to think anything to make regex
> expressions stand out is a good idea.
I think they do stand out a bit already with the extra {{'s, but sure,
explicitly putting -re on the directives makes them stand out even
more.
Anyway, I'm curious to hear what Richard thinks here.
- Hans
More information about the cfe-commits
mailing list