[PATCH] Refactor duplicate functions

Renato Golin renato.golin at linaro.org
Thu Dec 12 06:50:38 PST 2013


  committed in 197153


================
Comment at: lib/Driver/ToolChain.cpp:192
@@ -299,1 +191,3 @@
+      ? tools::arm::getLLVMArchSuffixForARM(tools::arm::getARMCPUForMArch(Args, Triple))
+      : tools::arm::getLLVMArchSuffixForARM(tools::arm::getARMTargetCPU(Args, Triple));
     bool ThumbDefault = Suffix.startswith("v6m") || Suffix.startswith("v7m") ||
----------------
This is very cryptic, but still better than before. I'd recommend a comment before that explaining a bit of why this is like that. Better names for those functions would also be good, even if a little verbose.


http://llvm-reviews.chandlerc.com/D2243

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list