[PATCH] Refactor duplicate functions

Jim Grosbach grosbach at apple.com
Wed Dec 11 18:45:10 PST 2013


Since Tim’s OK with it, that’s good enough for me. If there are any problems, we can sort it out post-commit.

Thanks!
-Jim

On Dec 11, 2013, at 5:54 AM, Tim Northover <t.p.northover at gmail.com> wrote:

>> I think the patch is good, if not pretty, so I'd like to commit. Can anyone
>> comment on whether the tests are enough to guarantee preservation of the
>> existing Darwin behaviour?
> 
> I think they looks reasonable. They cover the things I care about at
> the moment anyway. I think you should go for it. (And very sorry for
> the long delay in getting this committed. I know it wasn't exactly
> your idea in the first place).
> 
> Cheers.
> 
> Tim.





More information about the cfe-commits mailing list