[PATCH] section attribute subjects

[Aaron Ballman]

Good point; I've updated the code accordingly.

~Aaron

On Wed, Dec 11, 2013 at 9:04 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> D'oh, I reversed the sense of my comment while editing it. I think you
> should use hasGlobalStorage here, since it more clearly indicates what
> you're testing for.
>
>
> On Wed, Dec 11, 2013 at 5:39 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> Thanks! I've committed in r197104.  Btw, the GlobalVar subset subject
>> was already using !hasLocalStorage. The SharedVar was the one using
>> hasGlobalStorage.
>>
>> ~Aaron
>>
>> On Wed, Dec 11, 2013 at 7:54 PM, Richard Smith <richard at metafoo.co.uk>
>> wrote:
>> > LGTM, sorry for the delay! One thing: maybe use !hasLocalStorage()
>> > rather
>> > than hasGlobalStorage() in the definition of GlobalVar?
>> >
>> >
>> > On Wed, Dec 11, 2013 at 9:34 AM, Aaron Ballman <aaron at aaronballman.com>
>> > wrote:
>> >>
>> >> Ping
>> >>
>> >> On Fri, Dec 6, 2013 at 8:56 AM, Aaron Ballman <aaron at aaronballman.com>
>> >> wrote:
>> >> > Ping?
>> >> >
>> >> > On Mon, Dec 2, 2013 at 5:11 PM, Aaron Ballman
>> >> > <aaron at aaronballman.com>
>> >> > wrote:
>> >> >> This patch adds an explicit Subjects clause to the section
>> >> >> attribute,
>> >> >> and makes the subject diagnostic more consistent with other
>> >> >> attributes. As far as I can tell from looking at the code and online
>> >> >> documentation, the section attribute only applies to global variable
>> >> >> definitions and functions, which is how I arrived at the Subjects
>> >> >> list
>> >> >> proposed.
>> >> >>
>> >> >> ~Aaron
>> >> _______________________________________________
>> >> cfe-commits mailing list
>> >> cfe-commits at cs.uiuc.edu
>> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>> >
>> >
>
>