[PATCH] Change semantics of regex expectations in the diagnostic verifier

[Alp Toker]

On 11/12/2013 23:41, Hans Wennborg wrote:
> Hi Alp,
>
> On Wed, Dec 11, 2013 at 3:38 PM, Alp Toker <alp at nuanti.com> wrote:
>> On 11/12/2013 22:07, Hans Wennborg wrote:
>>> +// Add the characters from FixedStr to RegexStr, escaping as needed.
>>> This
>>> +// avoids the need for backslash-escaping in common patterns.
>>>
>>> +static void AddFixedStringToRegEx(StringRef FixedStr, std::string
>>> &RegexStr) {
>>> +  // FIXME: Expose FileCheck.cpp's Pattern::AddFixedStringToRegEx as a
>>> utility
>>> +  // method in RegEx.
>>
>> Just a drive-by comment, but any reason not to go ahead and put this or
>> similar right in Regex::escape()?
> This is exactly what I'll do :)

You're a star!

Alp.

>   - Hans

-- 
http://www.nuanti.com
the browser experts