[PATCH] Only strip underscores for GNU attributes

[Aaron Ballman]

Ping

On Thu, Dec 5, 2013 at 3:16 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> Currently, attribute names that have surrounding double underscores
> will have them stripped silently when determining the attribute kind.
> However, this doesn't make sense for all forms of attributes. For
> instance: __declspec(__dllexport__) should not be a valid attribute
> name, nor should [[__carries_dependency__]]
>
> This patch checks the attribute form and only strips the underscores
> for GNU attributes. However, it does also handle C++11-style GNU
> attribute as well, because there are existing test cases checking for
> that. Do we want to have the same behavior for C++11-style clang
> attributes?
>
> ~Aaron