[PATCH] Remove PragmaIntroducerKind?

Alp Toker alp at nuanti.com
Wed Dec 11 07:11:35 PST 2013


On 11/12/2013 14:31, Renato Golin wrote:
> On 11 December 2013 14:28, Enea Zaffanella <zaffanella at cs.unipr.it> wrote:
>> This is a callback and there is code outside of clang using it.
>> The source location passed down together with the introducer kind is the one
>> of the token *following* the introducer (if I am not wrong), so it would not
>> be immediate for clients to re-lex to see which introducer it was.
> Oh, I see. It looked suspiciously useful, this is why I thought it was
> left-over.
>
> I'll add your explanation as a comment, so that others don't fall into
> the same trap, too. ;)

If the feature is only usable / testable through a callback, it looks 
like a case where a unit test might actually be useful.

Enea / Renato, think you could cook one up?

Alp.

>
> cheers,
> --renato
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts




More information about the cfe-commits mailing list