[PATCH] Select correct embedded libclang_rt on Darwin

Tim Northover t.p.northover at gmail.com
Wed Dec 11 05:16:53 PST 2013


Hi,

We're trying to make using the OS X equivalent of an "arm-none-eabi" compiler simpler for users, and this patch should teach clang how to automatically link against the embedded libclang_rt builds I created recently.

The patch here is an interim solution, based on the fact that the triples involved are "*-*-darwin-eabi" at the moment. Longer term, this is an incorrect characterisation (they're not Darwin) and I'm planning to separate out the MachO specific toolchain pieces from the Darwin ones along more sensible lines, and start using "*-*-none-macho" as the triple.

But I think that the refactoring needed to support this patch will actually leave the interfaces cleaner even after the embedded part is stripped out (IOS, IOSSim and MacOSX are mutually exclusive and will cover the configuration-space, making an inconsistent check like "isIOSSim && isMacOSX" impossible).

Does this look good?

Cheers.

Tim.

http://llvm-reviews.chandlerc.com/D2380

Files:
  lib/Driver/ToolChains.cpp
  lib/Driver/ToolChains.h
  lib/Driver/Tools.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2380.1.patch
Type: text/x-patch
Size: 17247 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131211/2c7afeb0/attachment.bin>


More information about the cfe-commits mailing list