[PATCH] Fix "modular" import when we find the header in the current directory

Daniel Jasper djasper at google.com
Tue Dec 10 12:59:12 PST 2013


  These aren't dormant errors in the module.map of the declare-use tests, it is intended design. We only want to display these warnings if the corresponding modules are actively built. This is quite important. As a user, you might otherwise get a lot of warnings that you can't fix (as they are in somebody else's module). However, you still want to be enable this check for your own module. We could also check indirect modules guarded on an additional -fmodules-indirect-check flag, but I personally think that this is unnecessary complexity.

  Interestingly, I can't from the patch tell why it would now find these extra errors. verifyModuleInclude still tests that the RequestingModule is the current SourceModule. I'll take a close look tomorrow.

http://llvm-reviews.chandlerc.com/D2374



More information about the cfe-commits mailing list