[PATCH] clang-check should ignore -no-integrated-as because certain drivers can't handle it

[Artyom Skrobov]

Simon, thank you for this explanation.

If I understand it correctly, our proposed change would prevent the second job from being created -- defeating the purpose of this test?

OTOH, how would you expect this test to be handled by the drivers that are incapable of invoking external assembler?
Becoming somewhat pointless with the drivers that cannot create the second job, does it need a permanent REQUIRES: statement, in place of the XFAIL?


-----Original Message-----
From: Simon Atanasyan [mailto:simon at atanasyan.com] 
Sent: 10 December 2013 11:28
To: Artyom Skrobov
Cc: cfe-commits at cs.uiuc.edu; Scott Douglass
Subject: Re: [PATCH] clang-check should ignore -no-integrated-as because certain drivers can't handle it

On Tue, Dec 10, 2013 at 2:59 PM, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:
>> Do we know why Clang::Tooling/multi-jobs.cpp has '--no-integrated-as'
>> in the first place?
>
> No, but it's been there since the beginning (r156478).
> I'm copying Simon Atanasyan and Manuel Klimek who created/reviewed the
> original test, and may be able to shed some light on the purpose of
> --no-integrated-as there.

This test checks ClangSyntaxOnlyAdjuster. If we pass -no-integrated-as
option to the clang, it starts two jobs. The first one produces
assembler file. The second one runs external assembler to generate an
object file. The goal of the ClangSyntaxOnlyAdjuster is to add
-fsyntax-only option to the command line. With that option clang
changes behaviour and does not start external assembler.

-- 
Simon