r196854 - Fix via-file-asm test failure on windows

Reid Kleckner rnk at google.com
Mon Dec 9 19:39:14 PST 2013


There's still an assert here I'd like to get fixed.  If you remove the
target we still crash.


On Mon, Dec 9, 2013 at 4:54 PM, David Peixotto <dpeixott at codeaurora.org>wrote:

> Author: dpeixott
> Date: Mon Dec  9 18:54:30 2013
> New Revision: 196854
>
> URL: http://llvm.org/viewvc/llvm-project?rev=196854&view=rev
> Log:
> Fix via-file-asm test failure on windows
>
> The windows target does not support using an external assembler so
> the test case was failing with this error:
>
> error: there is no external assembler that can be used on this platform
>
> The test was updated to always explicitly pass a target that has
> both an interal and external assembler.
>
> Modified:
>     cfe/trunk/test/Driver/via-file-asm.c
>
> Modified: cfe/trunk/test/Driver/via-file-asm.c
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/via-file-asm.c?rev=196854&r1=196853&r2=196854&view=diff
>
> ==============================================================================
> --- cfe/trunk/test/Driver/via-file-asm.c (original)
> +++ cfe/trunk/test/Driver/via-file-asm.c Mon Dec  9 18:54:30 2013
> @@ -1,14 +1,10 @@
>  // Should save and read back the assembly from a file
> -// RUN: %clang -integrated-as -via-file-asm %s -### 2>&1 | FileCheck %s
> +// RUN: %clang -target arm-none-linux-gnueabi -integrated-as
> -via-file-asm %s -### 2>&1 | FileCheck %s
>  // CHECK: "-cc1"
>  // CHECK: "-o" "[[TMP:[^"]*]]"
>  // CHECK: -cc1as
>  // CHECK: [[TMP]]
>
>  // Should not force using the integrated assembler
> -// RUN: %clang -no-integrated-as -via-file-asm %s -### 2>&1 | FileCheck
> --check-prefix=NO_IAS %s
> +// RUN: %clang -target arm-none-linux-gnueabi -no-integrated-as
> -via-file-asm %s -### 2>&1 | FileCheck --check-prefix=NO_IAS %s
>  // NO_IAS-NOT: "-cc1as"
> -
> -// Test arm target specifically for the same behavior
> -// RUN: %clang -target arm -integrated-as -via-file-asm %s -### 2>&1 |
> FileCheck %s
> -// RUN: %clang -target arm -no-integrated-as -via-file-asm %s -### 2>&1 |
> FileCheck --check-prefix=NO_IAS %s
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131209/9926ebd6/attachment.html>


More information about the cfe-commits mailing list