[PATCH] [PATCH][AArch64]Pattern match failures for truncate store	and extend load
    David Blaikie 
    dblaikie at gmail.com
       
    Mon Dec  9 11:34:11 PST 2013
    
    
  
  The same feedback I gave on http://llvm-reviews.chandlerc.com/D2348
  "Hi Hao,
  Generally it's accepted that if you sent code out for review it's
  because you aren't comfortable/confident in the change to submit it
  with post-commit review. In that case, you are committed to waiting
  for feedback to increase your confidence until it is ready to be
  committed. Sending something for review, then committed in the absence
  of feedback is a red flag - it looks like "I'm not sure about this
  patch, but I'm going to push it through anyway because I can't wait
  long enough for review".
  Is there some reason you originally thought this deserved pre-commit
  review but don't believe that's the case anymore?"
http://llvm-reviews.chandlerc.com/D2350
    
    
More information about the cfe-commits
mailing list