[PATCH][ARM] Added support for krait cpu

[Ana Pazos]

Thanks Evan and Renato for the review.

 

I have committed the paches:

 

[llvm] r196619 - Added support for mcpu krait

[clang] r196618 - Added support for mcpu krait

 

Ana.

From: cfe-commits-bounces at cs.uiuc.edu
[mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Ana Pazos
Sent: Thursday, December 05, 2013 12:02 AM
To: 'Evan Cheng';
reviews+D1752+public+433068a9f6f7983d at llvm-reviews.chandlerc.com; 'Renato
Golin'
Cc: 'llvm-commits'; cfe-commits at cs.uiuc.edu
Subject: RE: [PATCH][ARM] Added support for krait cpu

 

Hi Evan,

 

GAS is able to assemble VFP4 fused multiply add/sub instructions.

 

I confirmed with David Kipping that the krait flag is being added to gcc.
But I have no info on when the krait patches to gcc will be published.

 

We have two options at the moment:

- Add a "FIXME" comment as a reminder to remove the krait check when GNU
tools support krait cpu flag.

- Remove the krait check. This will imply always use the integrated
assembler when generating code for krait.

 

Let me know what you prefer.

 

Thanks,

Ana. 

 

From: Evan Cheng [mailto:evan.cheng at apple.com] 
Sent: Tuesday, December 03, 2013 6:10 PM
To: Ana Pazos
Cc: llvm-commits; cfe-commits at cs.uiuc.edu
Subject: Re: [PATCH][ARM] Added support for krait cpu

 

 

On Dec 3, 2013, at 4:00 PM, Ana Pazos <apazos at codeaurora.org> wrote:

 

Hello reviewers,

 

These patches add support for krait cpu in Clang and LLVM.

 

Notes:

-        Krait processor currently modeled as cortex-a9 and reuses the same
instruction itineraries.

-        Krait additionally has VFP4 (fused multiply add/sub) and hardware
division features enabled.

 

The patch for this looks fine to me.

 

-        Krait cpu is not recognized by the GNU assembler, so it is replaced
with march=armv7-a to avoid a lower march from being used.

 

Is this a temporary workaround? Would gas be able to assembly VFP4
instructions?

 

Evan

 

 

Let me know what you think.

 

Thanks,

Ana.

<0001-llvm-Added-support-for-mcpu-krait.patch><0001-clang-Added-support-for-
mcpu-krait.patch>_______________________________________________
llvm-commits mailing list
 <mailto:llvm-commits at cs.uiuc.edu> llvm-commits at cs.uiuc.edu
 <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131206/1ecdbfda/attachment.html>