[PATCH] C++11: Reject string literal to non-const char * conversion

[Ismail Pazarbasi]

Hi Richard,

could you please take another look at this patch?

On Tue, Nov 19, 2013 at 5:23 PM, Ismail Pazarbasi
<ismail.pazarbasi at gmail.com> wrote:
>   Changes since last revision:
>   * Changed diagnostics message.
>   * Removed superfluous `DeprecatedStringLiteralToCharPtr = false`.
>   * Added comments in CompareImplicitConversionSequences function.
>   * Added test for SFINAE failure.
>   * Changed tests to check syntax instead of IR
>
> Hi rsmith,
>
> http://llvm-reviews.chandlerc.com/D1965
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D1965?vs=5530&id=5658#toc
>
> Files:
>   include/clang/Basic/DiagnosticSemaKinds.td
>   lib/Sema/SemaExprCXX.cpp
>   lib/Sema/SemaOverload.cpp
>   test/SemaCXX/cxx0x-type-convert-construct.cpp
>   test/SemaCXX/deprecated.cpp
>   test/SemaCXX/overload-0x.cpp
>   unittests/ASTMatchers/ASTMatchersTest.cpp