r196487 - [libclang] Record ranges skipped by the preprocessor and expose them with libclang.

[Alp Toker]

On 06/12/2013 19:00, Argyrios Kyrtzidis wrote:
> On Dec 5, 2013, at 4:33 AM, Alp Toker <alp at nuanti.com> wrote:
>
>> On 05/12/2013 08:19, Argyrios Kyrtzidis wrote:
>>> +typedef struct {
>>> +  /** \brief The number of ranges in the \c ranges array. */
>>> +  unsigned count;
>>> +  /**
>>> +   * \brief An array of \c CXSourceRange, where each range starts at the
>>> +   * preprocessor directive after the # token, and ends at the end of the
>>> +   * corresponding endif.
>>> +   */
>>> +  CXSourceRange *ranges;
>>> +} CXSkippedRanges;
>>> +
>> CXSourceRangeList or CXRanges would be a more future-proof name for this type than CXSkippedRanges.
>>
>> It'll be a pain to rename or duplicate the type when another function comes along that also works in terms of sets of source ranges given that this API has a stability guarantee.
> Agreed. Made the change in r196591.
> Thanks for reviewing!

Thanks Argyrios!


>
>> Sorry I missed the review thread.
>>
>> -- 
>> http://www.nuanti.com
>> the browser experts
>>

-- 
http://www.nuanti.com
the browser experts