[PATCH] CMake: enable building the clang-format vs plugin

Hans Wennborg hans at chromium.org
Thu Dec 5 09:55:16 PST 2013


On Thu, Dec 5, 2013 at 1:00 AM, Manuel Klimek <klimek at google.com> wrote:
> On Thu, Dec 5, 2013 at 3:37 AM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> On Wed, Dec 4, 2013 at 5:39 PM, Josh Samuel <jsamuel at gmail.com> wrote:
>> >
>> >   LLVM_TOOLS_BINARY_DIR doesn't appear to be the correct directory to
>> > copy from when building from the CMake generated Visual Studio solution.
>> > It is copying the exe's to a subfolder of LLVM_TOOLS_BINARY_DIR that
>> > represents the build configuration (eg. bin\Release or bin\RelWithDebugInfo
>> > )
>>
>> Hmm, so does anyone know a good way of getting the *real* binary
>> output dir within cmake?
>
> If I'm not mistaken, the correct value is
> ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}

Thanks! That works. I verified that I can now build the vsix both with
ninja and an MSVC solution. Committed r196512.

Cheers,
Hans



More information about the cfe-commits mailing list