[PATCH] clang-check should ignore -no-integrated-as because certain drivers can't handle it

Artyom Skrobov Artyom.Skrobov at arm.com
Thu Dec 5 05:29:00 PST 2013


Hello,

r194968 (reviewed at http://llvm-reviews.chandlerc.com/D2039) has changed
the behaviour of clang-check w.r.t. -no-integrated-as argument: previously,
it was silently ignored; now, it's used to create the Compilation, and then
ignored further down the flow.

r194992 had to XFAIL test/Tooling/multi-jobs.cpp on the grounds that "MSVC
targeted drivers (*-win32) are incapable of invoking external assembler."
These drivers cannot create the Compilation when -no-integrated-as argument
is present.

Our patch restores the original behaviour, that is, silently ignoring
-no-integrated-as. This allows to un-XFAIL test/Tooling/multi-jobs.cpp.

OK to commit?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check-noias.patch
Type: application/octet-stream
Size: 1977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131205/5bdf6e04/attachment.obj>


More information about the cfe-commits mailing list