r195910 - InclusionRewriter: Avoid duplicated BOM check

Lubos Lunak l.lunak at centrum.cz
Tue Dec 3 15:44:45 PST 2013


On Tuesday 03 of December 2013, Alp Toker wrote:
> On 03/12/2013 20:01, Lubos Lunak wrote:
> > On Tuesday 03 of December 2013, Reid Kleckner wrote:
> >> This seems like it has the side effect of trimming leading whitespace
> >> from the rewritten file, but that's probably fine.
> >
> >   It's not. The main file does not start with any line markers, so it is
> > possible that lines in warnings/errors will be wrong. Please fix this or
> > revert the change to the previous one that works.
>
> Hi Lubos,
>
> I don't see the problem here. Can you explain, preferably with a test case?

 Never mind, the comment about stripped whitespace is apparently not true.

-- 
 Lubos Lunak



More information about the cfe-commits mailing list