[PATCH] Automated handling of language options for attributes

Aaron Ballman aaron at aaronballman.com
Mon Dec 2 11:35:15 PST 2013


On Mon, Dec 2, 2013 at 2:27 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> I guess the intent is to eventually switch over to generating
> include/clang/Basic/LangOptions.def with tablegen, with a shared .td file
> being used for both that and the attributes?

At some point, that would be nice. For right now, I took the cheap way
out and have explicitly declared the language options being used for
attributes.

> Please name your generated functions with a leading lowercase letter
> ("defaultDiagnoseLangOpts", "checkCPlusPlusLangOpts"); other than that,
> LGTM. Thank you!

Done, thanks!  Committed in r196138. I'll do a follow-up commit for
the appertainsTo names.

~Aaron



More information about the cfe-commits mailing list