[PATCH] [ms-cxxabi] Construct and destroy call arguments in the correct order
Richard Smith
richard at metafoo.co.uk
Mon Dec 2 11:20:20 PST 2013
================
Comment at: lib/CodeGen/CGExprCXX.cpp:277-278
@@ -275,3 +276,4 @@
// And the rest of the call args
- EmitCallArgs(Args, FPT, E->arg_begin(), E->arg_end());
+ EmitCallArgs(Args, FPT->isVariadic(), FPT->arg_type_begin(),
+ FPT->arg_type_end(), E->arg_begin(), E->arg_end());
return EmitCall(CGM.getTypes().arrangeCXXMethodCall(Args, FPT, required),
----------------
You seem to be doing this a lot. Have you considered retaining the old `EmitCallArgs` overload (making it a wrapper for the new thing)?
http://llvm-reviews.chandlerc.com/D2275
More information about the cfe-commits
mailing list