[PATCH] clang-format VS plugin: bake clang-format.exe into the plug-in to make it self-contained

Hans Wennborg hans at chromium.org
Mon Dec 2 09:17:25 PST 2013



================
Comment at: tools/clang-format-vs/README.txt:9-10
@@ +8,3 @@
+
+clang-format.exe must be copied into the ClangFormat/ directory before building.
+It will be bundled into the .vsix file.
----------------
Manuel Klimek wrote:
> I assume the build fails now if we don't do this?
Yes.

================
Comment at: tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs:132
@@ -130,1 +131,3 @@
         {
+            string vsixPath = Path.GetDirectoryName(Uri.UnescapeDataString(
+                new UriBuilder(Assembly.GetExecutingAssembly().CodeBase).Path));
----------------
Manuel Klimek wrote:
> Is that the  same as AppDomain.CurrentDomain.BaseDirectory?
No, that resolves to "C:\Program Files (x86)\Microsoft Visual Studio 11.0\Common7\IDE\" for me, whereas the plugin is actually buried inside "c:\Users\hans\AppData\Local\Microsoft\VisualStudio\11.0\extension\blah\"


http://llvm-reviews.chandlerc.com/D2281



More information about the cfe-commits mailing list