r195961 - Added LanguageStandard::LS_JavaScript to gate all JS-specific parsing.

Alexander Kornienko alexfh at google.com
Mon Dec 2 01:04:36 PST 2013


On Mon, Dec 2, 2013 at 9:27 AM, Daniel Jasper <djasper at google.com> wrote:

> On Sun, Dec 1, 2013 at 12:26 AM, Nico Weber <thakis at chromium.org> wrote:
>
>> unittests/Format/FormatTest.cpp is pretty large by now. Should
>> js-specific tests maybe go into a new file?
>>
>
> Sounds like a good idea to me.
>

It sounds like a good idea overall, we have to do something with our 7k+
LOC unit test file. I think though, that just the c++ part of the test is
already hardly manageable, so we need something else as well. We already
had a discussion about converting some (ideally, most) of the tests to
lit-based ones (with addition of a special preprocessing tool, maybe). We
didn't come to a consensus that time, but we should try again ;)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131202/2f9693f8/attachment.html>


More information about the cfe-commits mailing list