[ARM] OK to delete test/CodeGen/a5.c and test/CodeGen/a15.c ?
Daniel.Sanders at imgtec.com
Sat Nov 30 04:47:52 PST 2013
You're right that mips-clobber-reg.c is a frontend test. It's trying to trigger an assertion if we forgot to add support for any named registers in the clobber list of inline assembly.
It should probably have some output checks to make sure that the clobber list is passed on correctly. I'll take a look at doing that when I get the chance.
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of Alp Toker
> Sent: 22 November 2013 05:40
> To: Artyom Skrobov; cfe-commits at cs.uiuc.edu
> Subject: Re: [ARM] OK to delete test/CodeGen/a5.c and
> test/CodeGen/a15.c ?
> Sure Artyom, go ahead and please remove test/CodeGen/r5.c as well while
> you're at it.
> With those three gone, I see only two other tests remaining in CodeGen that
> don't check the output in any way:
> test/CodeGen/mips-clobber-reg.c: Looks like a Frontend test?
> test/CodeGen/attribute-section-data-common.c: No idea what this is.
> On 21/11/2013 16:44, Artyom Skrobov wrote:
> > Hello,
> > These two tests are apparently there with the sole purpose of ensuring
> > clang accepts -mcpu=cortex-a5 and -mcpu=cortex-a15
> > Those same options are tested, among many other things, in
> > test/Preprocessor/arm-target-features.c and
> > test/Driver/arm-cortex-cpus.c, so the two aforementioned tests seem
> totally redundant.
> > Does anyone mind me deleting these two tests?
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> the browser experts
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
More information about the cfe-commits