r195586 - remove gcc::Precompile
Rafael Espindola
rafael.espindola at gmail.com
Sun Nov 24 15:40:06 PST 2013
Author: rafael
Date: Sun Nov 24 17:40:06 2013
New Revision: 195586
URL: http://llvm.org/viewvc/llvm-project?rev=195586&view=rev
Log:
remove gcc::Precompile
Clang still has support for running gcc for performing various stages
of a build. Right now it looks like this is used for
* Supporting Fortran in the clang driver
* Running an assembler or linker in systems we don't yet know how to
run them directly.
It looks like the gcc::Precompile is a vestige from the days when we
supported using clang for C and running gcc for c++. This patch removes it
(yes, we have no tests for it).
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Driver/Tools.h
Modified: cfe/trunk/lib/Driver/ToolChains.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=195586&r1=195585&r2=195586&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains.cpp Sun Nov 24 17:40:06 2013
@@ -1574,10 +1574,6 @@ Tool *Generic_GCC::getTool(Action::Actio
if (!Preprocess)
Preprocess.reset(new tools::gcc::Preprocess(*this));
return Preprocess.get();
- case Action::PrecompileJobClass:
- if (!Precompile)
- Precompile.reset(new tools::gcc::Precompile(*this));
- return Precompile.get();
case Action::CompileJobClass:
if (!Compile)
Compile.reset(new tools::gcc::Compile(*this));
Modified: cfe/trunk/lib/Driver/ToolChains.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.h?rev=195586&r1=195585&r2=195586&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains.h (original)
+++ cfe/trunk/lib/Driver/ToolChains.h Sun Nov 24 17:40:06 2013
@@ -183,7 +183,6 @@ protected:
private:
mutable OwningPtr<tools::gcc::Preprocess> Preprocess;
- mutable OwningPtr<tools::gcc::Precompile> Precompile;
mutable OwningPtr<tools::gcc::Compile> Compile;
};
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=195586&r1=195585&r2=195586&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Sun Nov 24 17:40:06 2013
@@ -4263,11 +4263,6 @@ void gcc::Preprocess::RenderExtraToolArg
CmdArgs.push_back("-E");
}
-void gcc::Precompile::RenderExtraToolArgs(const JobAction &JA,
- ArgStringList &CmdArgs) const {
- // The type is good enough.
-}
-
void gcc::Compile::RenderExtraToolArgs(const JobAction &JA,
ArgStringList &CmdArgs) const {
const Driver &D = getToolChain().getDriver();
Modified: cfe/trunk/lib/Driver/Tools.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.h?rev=195586&r1=195585&r2=195586&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.h (original)
+++ cfe/trunk/lib/Driver/Tools.h Sun Nov 24 17:40:06 2013
@@ -139,18 +139,6 @@ namespace gcc {
llvm::opt::ArgStringList &CmdArgs) const;
};
- class LLVM_LIBRARY_VISIBILITY Precompile : public Common {
- public:
- Precompile(const ToolChain &TC) : Common("gcc::Precompile",
- "gcc precompile", TC) {}
-
- virtual bool hasGoodDiagnostics() const { return true; }
- virtual bool hasIntegratedCPP() const { return true; }
-
- virtual void RenderExtraToolArgs(const JobAction &JA,
- llvm::opt::ArgStringList &CmdArgs) const;
- };
-
class LLVM_LIBRARY_VISIBILITY Compile : public Common {
public:
Compile(const ToolChain &TC) : Common("gcc::Compile",
More information about the cfe-commits
mailing list